Create sp for each e2e run #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run ci,e2e |
|
Don't we need the unique SPs for the production E2E? |
rolandmkunkel
force-pushed
the
mociarain/create-sp-for-each-e2e-run
branch
from
b310715
to
fe0eafd
Compare
mociarain
force-pushed
the
mociarain/create-sp-for-each-e2e-run
branch
2 times, most recently
from
9d5697d
to
b05cc92
Compare
Not in the new tenant 😎 |
mociarain
commented
Jul 18, 2024
| @@ -714,13 +728,28 @@ func (c *Cluster) deleteCluster(ctx context.Context, resourceGroup, clusterName | |||
| return nil | |||
| } | |||
|
|
|||
| func (c *Cluster) deleteClusterResourceGroup(ctx context.Context, resourceGroup string) error { | |||
| func (c *Cluster) ensureResourceGroupDeleted(ctx context.Context, resourceGroupName string) error { | |||
There was a problem hiding this comment.
This was added due to some racey deletions and some stuff not getting cleaned up correctly in the new tenant. AFAIK in the past we were letting the VnetRG get cleaned up via the purge:true flag (https://github.com/Azure/ARO-RP/pull/3513/files @tsatam can you confirm this). This just makes all the deletion a bit more explicit but we still have the purge script as a fall back
|
/azp run ci |
mociarain
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter and
SudoBrendan
as code owners
|
Azure Pipelines successfully started running 1 pipeline(s). |
mociarain
changed the title
mociarain
force-pushed
the
mociarain/create-sp-for-each-e2e-run
branch
from
dcb5ece
to
042fc45
Compare
mociarain
force-pushed
the
mociarain/create-sp-for-each-e2e-run
branch
from
042fc45
to
a941ecd
Compare
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bitoku
reviewed
Jul 19, 2024
tiguelu
reviewed
Jul 19, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tiguelu
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Ticket
This PR: